Skip to content

chore: Switch Google web sign-in to the redirect flow#497

Merged
Zfinix merged 7 commits into
mainfrom
docs/google-web-redirect-flow
May 26, 2026
Merged

chore: Switch Google web sign-in to the redirect flow#497
Zfinix merged 7 commits into
mainfrom
docs/google-web-redirect-flow

Conversation

@Zfinix
Copy link
Copy Markdown
Contributor

@Zfinix Zfinix commented May 13, 2026

Summary

  • Switches the documented Google web sign-in flow to the OAuth2 redirect path (flutter_web_auth_2 + auth.html). The popup/iframe flow is no longer the default in the docs.
  • Adds a shared Web callback page (auth.html) section under concepts/authentication/setup so GitHub, Google, and any future redirect-based IdP reference one canonical place.
  • Rewrites the Google Web subsection, OAuth client URI table, passwords.yaml examples (dev + prod), initializeGoogleSignIn example (clientId + redirectUri under kIsWeb), and the Publishing-to-production redirect URI to use /app/auth.html (the standard template path).
  • Updates the Google troubleshooting page for redirect-mode failure modes (callback never returns, clientId is required, redirect_uri_mismatch across all three configuration spots) and drops popup-only entries.
  • Updates GitHub setup to reference the shared auth.html section instead of inlining the snippet.
  • Adds a "Configuring the Web redirect URI" subsection to Google customizations covering the --dart-define pattern.

Supersedes #494. Most of the redirect-flow content originated from @vfiruz97's work there; this PR re-applies that intent on top of the recently merged #490.

Requires serverpod_auth_idp_flutter >= 3.5.0-beta.7 (the version that adds the redirectUri parameter to initializeGoogleSignIn).

@Zfinix Zfinix changed the title docs: refactor docs for google web redirect flow docs: Switch Google web sign-in to the redirect flow May 13, 2026
@Zfinix Zfinix changed the title docs: Switch Google web sign-in to the redirect flow chore: Switch Google web sign-in to the redirect flow May 13, 2026
@Zfinix Zfinix requested review from Swiftaxe and vfiruz97 and removed request for Swiftaxe May 14, 2026 07:06
Copy link
Copy Markdown
Contributor

@vfiruz97 vfiruz97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment thread docs/06-concepts/11-authentication/04-providers/03-google/01-setup.md Outdated
@Zfinix Zfinix self-assigned this May 14, 2026
@Zfinix Zfinix marked this pull request as ready for review May 18, 2026 06:57
@Zfinix Zfinix marked this pull request as draft May 18, 2026 08:01
@Zfinix Zfinix requested a review from Swiftaxe May 18, 2026 08:01
@Zfinix Zfinix marked this pull request as ready for review May 22, 2026 06:52
@Zfinix Zfinix requested a review from vfiruz97 May 22, 2026 06:52
Comment thread docs/06-concepts/11-authentication/04-providers/03-google/01-setup.md Outdated
Comment thread docs/06-concepts/11-authentication/04-providers/03-google/01-setup.md Outdated
Comment thread docs/06-concepts/11-authentication/04-providers/03-google/02-customizations.md Outdated
Comment thread docs/06-concepts/11-authentication/04-providers/03-google/02-customizations.md Outdated
Comment thread docs/06-concepts/11-authentication/04-providers/03-google/01-setup.md Outdated
Comment thread docs/06-concepts/11-authentication/04-providers/03-google/01-setup.md Outdated
Comment thread docs/06-concepts/11-authentication/04-providers/03-google/01-setup.md Outdated
Comment thread docs/06-concepts/11-authentication/04-providers/03-google/04-troubleshooting.md Outdated
Copy link
Copy Markdown
Contributor

@vfiruz97 vfiruz97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good doc. Technically looks correct but I put some suggestions as personally I like short docs. Address them and discuss with team as they are from user prospective.

Comment thread docs/06-concepts/11-authentication/04-providers/03-google/02-customizations.md Outdated
Comment thread docs/06-concepts/11-authentication/01-setup.md
@Zfinix Zfinix requested a review from vfiruz97 May 26, 2026 09:42
@Zfinix Zfinix requested a review from Swiftaxe May 26, 2026 09:42
Copy link
Copy Markdown
Contributor

@vfiruz97 vfiruz97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good update! Let's see @Swiftaxe review.

Copy link
Copy Markdown
Collaborator

@Swiftaxe Swiftaxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Zfinix Zfinix merged commit 1c9fb27 into main May 26, 2026
1 check passed
@Zfinix Zfinix deleted the docs/google-web-redirect-flow branch May 26, 2026 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants